iprodanovbg / homeassistant-desktop

🎛 Desktop application (Windows / macOS / Linux) for Home Assistant built with Electron
Apache License 2.0
394 stars 39 forks source link

[v1.5.2] Weird/wrong/no interpretation of CS styles #7

Closed bcutter closed 1 year ago

bcutter commented 1 year ago

After updating from v1.5.1 to v1.5.2 formerly perfectly nice buttons are now shown different which breaks the UI in many places. Few random examples:

grafik

grafik

Likely does not respect this CSS inside all custom:restriction-card elements:

            card_mod:
              style:
                .: |
                  ha-card {
                    aspect-ratio: 1/1
                  }

Probably related to Temporary revert electron version to fix random crashes in https://github.com/iprodanovbg/homeassistant-desktop/releases/tag/v1.5.2

I have no idea what electron version now runs this app (maybe a pretty old one?), but well, it broke things.

Why can't we switch back to the electron version used in v1.5.1 and try fix the app crash bug instead? We now avoided to fix that bug by switching electron version - which introduced few new bugs...

iprodanovbg commented 1 year ago

Hello,

In this version of electron, "aspect-ratio" is not yet implemented, so if it is custom code, I can suggest you to use flex with align-items: stretch;.

Why can't we switch back to the electron version used in v1.5.1 and try fix the app crash bug instead? We now avoided to fix that bug by switching electron version - which introduced few new bugs...

I still can't find a solution to crash issue, so I decided to revert the changes. You can disable automatic updates and install an older version until this problem is fixed.

bcutter commented 1 year ago

You can disable automatic updates and install an older version until this problem is fixed.

That's unfortunately exactly the only option I see. I don't want to start changing all my (perfectly working) dashboards/views because of one single application in one OS which isn't showing things correctly.

Let's see what annoys more over time: crashing application or malformed UI, 1.5.1 or 1.5.2, red or blue pill... I'll see.

Just leave this issue open until the "electron crash bug" (if it's really related to it) has been fixed and HA Desktop starts to show dashboards/views right again.

bcutter commented 1 year ago

I still can't find a solution to crash issue, so I decided to revert the changes

Did you meanwhile investigate the crash issues of the newer version?

I still think downgrading the core component because of a crashing issue - which results in the downgraded version creating several other issues like #6 and #7/this one - is not a good decision.

Going back using horses because cars are bad for the environment is not a solution either, isn't it 😄

iprodanovbg commented 1 year ago

Sorry for the delay, there is a new version that will fix this issue

bcutter commented 1 year ago

Sorry for the delay, there is a new version that will fix this issue

I will test it asap (in 2 to 3 days) and report back.

bcutter commented 1 year ago

v1.5.3 fixed this for me (quick check), even I don't see what in 1.5.3 fixed it as the release notes don't mention anything bout that.