search

ipsilon / eof

Validation code for the EOF specification
Apache License 2.0
43 stars 19 forks source link

Remove duplicate formulation of admissible header item entries #143

Closed pdobacz closed 3 months ago

pdobacz commented 4 months ago

This is a follow up of #141 There were other entries off in this table. I also think we should not duplicate the ranges in the bullet points above, so I removed these and had the reader refer to the table.

WDYT?

gumb0 commented 4 months ago

Yes, this is good. However, maybe we should use decimal values in the table? I think 1024 is better than 0x0400.

I like it in hex, because you can clearly see that the value fits into two bytes.

pdobacz commented 3 months ago

OK, then I'll merge here and open a mirror PR in the EIP