search

ipsilondev / openfl-unityads

UnityAds implementation for OpenFL/Haxe
MIT License
16 stars 1 forks source link

onVideoCompleted specification #6

Closed andrew-git closed 8 years ago

andrew-git commented 8 years ago

In integration guide for android (http://unityads.unity3d.com/help/monetization/integration-guide-android) onVideoCompleted listener has 2nd parameter skipped

onVideoCompleted(String itemKey, boolean skipped) listener If skipped is false, the player has watched an ad, and should be rewarded.

In documentation for your extension you wrote

   UnityAds.onVideoCompleted = function(key:String,reward:Bool):Void {
        Lib.trace("onVideoCompleted = "+key+" = "+reward);
    };

Second parameter named "reward" and so have opposite meaning. Is it mistake (and better correct and rename accordingly to unity documentation) or you revert returning value inside your extension?

Thanks for extension and your work!

shadowofsoul commented 8 years ago

no, the value is directly passed from unityAds SDK to the callback function. thanks for the notice, i will change the name of the variable on next release, i suppose they changed that at some point and i never realized it.

andrew-git commented 8 years ago

Thanks!