search

ipsilondev / openfl-unityads

UnityAds implementation for OpenFL/Haxe
MIT License
16 stars 1 forks source link

Any plans to update iOS to 2.0? #9

Open mastef opened 7 years ago

mastef commented 7 years ago

Running into some memory issues on iPad 2 when unity ads are loaded. Not sure if UnityAds is the culprit, but basically receiving memory warnings on a 12MB app, and crash when "Campaign data received".

Gonna find out now if there were any relevant patches after UnityAds SDK 1.5.6.

Any plans to update to latest version from https://github.com/Unity-Technologies/unity-ads-ios ?

shadowofsoul commented 7 years ago

Hey there.

unfortunately we moved away from haxe / openfl to make games (we are using unity). so the short answer is no.

anyway, this code was done only supporting legacy mode of openfl (at that time, there was no extension support on NEXT version of openfl). now i suppose there is extension support and works why you at least can compile it. To give you some help on this, most probably you only need to update the framework, and maybe it will work (from here https://github.com/Unity-Technologies/unity-ads-ios/releases ). maybe you are going to need to remove the .bundle of unityads ( or not ) as i can see, is not included in the unity package anymore. If updating the framework doesn't work, you need to go deeper, and that could from how i make the calls in the plugin to the native code (done here: https://github.com/ipsilondev/openfl-unityads/blob/master/extension/unityads/UnityAds.hx ) to the native code in the ndll (here: https://github.com/ipsilondev/openfl-unityads/blob/master/project/common/openflunityads.mm ). if you are on this point, i would look at the code that generate the window / context to show the ads, that's usually the culprit when there is a memory leak.

i hope it helps. I would love to help you out more, but truth to be told, i have tons of things to do for the company, and i can't give support to this library. debugging this would take me hours and i'm not even using it :(

i love open source, but i have a company to maintain and i need to do other stuff that would make money :(

mastef commented 7 years ago

Hey no worries, thanks for the lengthy reply! :)

In fact we're still using legacy as haxeflixel is not ported to next yet, but after investigating more UnityAds 1.5.x was not the mem culprit - soo, no need to update for now.

For anybody who wants to port to the next 2.0.0 here's a good migration guide additionally to @shadowofsoul's comment above : https://github.com/Unity-Technologies/unity-ads-ios/wiki/sdk_ios_transition_guide