ipsn / go-libtor

Self-contained Tor from Go
BSD 3-Clause "New" or "Revised" License
544 stars 46 forks source link

Warning when running in docker #34

Open neo4u opened 2 years ago

neo4u commented 2 years ago

Hi Team,

I'm getting this warning when doing docker build in my go project that uses this library:

#10 257.1 # github.com/ipsn/go-libtor/libtor
#10 257.1 In file included from /go/pkg/mod/github.com/ipsn/go-libtor@v1.0.380/libtor/../tor/src/../src/lib/crypt_ops/crypto_rand.c:70,
#10 257.1                  from /go/pkg/mod/github.com/ipsn/go-libtor@v1.0.380/libtor/tor_src_lib_crypt_ops_crypto_rand.go:9:
#10 257.1 /usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Wcpp]
#10 257.1     1 | #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
#10 257.1       |  ^~~~~~~
#10 DONE 260.1s

Any idea as to how to fix? I know it's just a warning, but wanted to avoid a future error due to header linkage.

neo4u commented 2 years ago

I think the fix maybe to change this from

#include <sys/fcntl.h>

to

#include <fcntl.h>

Like in this PR for a different project using the same library.

neo4u commented 2 years ago

@karalabe Let me know if this makes sense to do?