search

ipspace / netlab

Making virtual networking labs suck less
https://netlab.tools
Other
409 stars 58 forks source link

Fix the checking for stub_loopback feature #1175

Closed jbemmel closed 2 months ago

jbemmel commented 2 months ago

Enable it by default for SR Linux devices

Fixes isis/12-passive.yml test case

ipspace commented 2 months ago

I think you misunderstood what's going on here. This feature enables the user to turn stub links into loopbacks if they want. The code you 'fixed' disables that features on per-device basis, that's why it checks for False.

See https://netlab.tools/links/#loopback-links for details.

ipspace commented 2 months ago

This was a tricky one -- a True feature is converted into a Box({}) to support things like ospf: True.

Fixed in e2ca48d333d7cbf547a6798f06ac76730f67d3d7 -- you can set stub_loopback: True in device features if you wish.