Generic routing module (routing policies)

ipspace / netlab

Making virtual networking labs suck less

https://netlab.tools

Other

428 stars 63 forks source link

Generic routing module (routing policies) #1234

Closed ipspace closed 1 month ago

ipspace commented 1 month ago

The generic routing module implements route maps (routing.policy) which can be used in bgp.policy plugin with bgp.policy.in and bgp.policy.out interface attributes.

bgp.policy plugin has been modified to use the shared route-map infrastructure and activate 'routing' module whenever necessary.

The configuration templates for all devices supported by the bgp.policy plugin have been split into route-map and BGP parts, and the route-map part moved into the 'routing' module.

ipspace commented 1 month ago

Missing:

[ ] bgp.policy should copy attribute definitions and device support data from the routing module
[x] routing module should check the feature support when a route-map is applied to a node
[x] test- and error cases
[x] documentation

Also:

No work has been done (yet) on the bgp.policy attribute

cloudflare-pages[bot] commented 1 month ago

Deploying netlab-release with Cloudflare Pages

Latest commit:	`3ceacb0`
Status:	✅ Deploy successful!
Preview URL:	https://648b81e5.netlab-release.pages.dev
Branch Preview URL:	https://routing-module.netlab-release.pages.dev

View logs

ipspace commented 1 month ago

Implemented:

Route map merging
Device feature support
bgp.policy.in and bgp.policy.out interface attributes
Integration tests mirroring the bgp.policy integration tests
Test and error cases for routing.policy

Missing:

[x] routing.policy data type errors stress test
[x] bgp.policy / routing.policy integration error tests
[x] documentation
[ ] bgp.policy should copy attribute definitions and device support data from the routing module

ipspace commented 1 month ago

FWIW, this is ready for review. Will implement 'copy attributes from routing to bgp.policy' after the merge.

Also, I will probably submit the changes as several commits, not as a single PR.

ipspace commented 1 month ago

All looks wonderful ;) thank you! (also for the "merge" of arubacx route maps with ios)

(I also did some additional tests (with arubacx and vyos), and all worked)

Thanks a million ;) I know it was quite a lot to go through.

ipspace commented 1 month ago

Implemented in #1238 and #1239

ipspace commented 1 month ago

The remaining work has been copied into #1240