ipspace / netlab

Making virtual networking labs suck less
https://netlab.tools
Other
428 stars 63 forks source link

bgp.policy plugin should use attribute definitions from routing.policy #1240

Closed ipspace closed 1 month ago

ipspace commented 1 month ago

bgp.policy plugin provides a shortcut way of adding route-maps (or standalone attributes like 'weight') to BGP sessions. It defines the same attributes as the 'routing' module does for the 'rp_entry' top-level attribute. The same happens with device data -- supported features are defined under devices in features.routing.set as well as in the bgp.policy.yml file

Data duplication is never a good idea. bgp.policy should copy attribute definitions and device support data from the routing module