search

ipspace / netlab

Making virtual networking labs suck less
https://netlab.tools
Other
428 stars 63 forks source link

Implement 'match.prefix' in routing policies #1244

Closed ipspace closed 1 month ago

cloudflare-pages[bot] commented 1 month ago

Deploying netlab-release with  Cloudflare Pages  Cloudflare Pages

Latest commit: 002b787
Status: ✅  Deploy successful!
Preview URL: https://7ad1a700.netlab-release.pages.dev
Branch Preview URL: https://aspath.netlab-release.pages.dev

View logs

ipspace commented 1 month ago

I don't know if it could be worth having at the "general level" the same logic you implemented for different route maps also for prefix lists. Otherwise I will implement it only for Aruba templates

I guess there might be other crap out there with similar limitations, so let's go for the same logic applied everywhere. Will you fix that in all related places or shall I?

ipspace commented 1 month ago

I guess there might be other crap out there with similar limitations, so let's go for the same logic applied everywhere. Will you fix that in all related places or shall I?

You know what, let me fix that, so it will be a separate commit, and I can immediately run the integration tests.

ipspace commented 1 month ago

I don't know if it could be worth having at the "general level" the same logic you implemented for different route maps also for prefix lists.

Implemented in 686789904a5662310dc6c7da67b909a606345f74. Go ahead ;)

ssasso commented 1 month ago

ready for aruba ;) vyos will require some more time.