search

ipspace / netlab

Making virtual networking labs suck less
https://netlab.tools
Other
428 stars 63 forks source link

Implement as-path access lists and match.aspath in routing policies #1247

Closed ipspace closed 1 month ago

cloudflare-pages[bot] commented 1 month ago

Deploying netlab-release with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c40ffc
Status: ✅  Deploy successful!
Preview URL: https://f44914cf.netlab-release.pages.dev
Branch Preview URL: https://aspath.netlab-release.pages.dev

View logs

ipspace commented 1 month ago
  1. you forgot to add the devices/xxxxxx.yml files

Even worse, I managed to pass the integration tests 🤦‍♂️

The test topology used a very specific setup (node AS-path filter and routing policy) that did not trigger "does this work here" check. I fixed that check to make Aruba integration test fail (because AS-path ACL is not implemented yet) but forgot the side effects 🤷‍♂️

  1. while most probably this works with FRR 9, on version 7.5 (which - if I recall correctly - is also the one used on bgplabs) bgp as-path cannot have seq.

Thank you, fixed (and yeah, FRR 9 has AS-path ACL sequence numbers, but it's the only device I work with that does)