ipspace / netlab

Making virtual networking labs suck less
https://netlab.tools
Other
430 stars 64 forks source link

Link and module attributes in address pools #567

Closed ipspace closed 1 year ago

ipspace commented 1 year ago

OK, I opened a can of worms in #566 -- if we allow extra attributes in prefixes, why wouldn't we go all the way and add link- and module-link attributes to address pools. This might come handy once we implement default gateway module; it wouldn't be fun to have to specify anycast gateway on every link in the topology.

ipspace commented 1 year ago

Scratch this one, it was a bad idea. Prefixes are assigned to links somewhere in the middle of links.transform and half of the module-specific stuff has already been done by that time. Copying raw module attributes to links at that time is dangerous, and I will not go through the "oh, but I want to list the VRFs and VLANs in group node_data" exercise again.