search

ipsum-community / ipsum-community.github.io

MIT License
12 stars 2 forks source link

Add Shakespeare ipsum #36

Closed Steven24K closed 3 years ago

Steven24K commented 3 years ago

Hi @Sena ,

I found your Lorum Ipsum generator on the web. Intersting concept, I have seen many different kind of ipsums on the web (bacon psum is really nice) and I use them on testing environments for dummy content. This makes working with dummy text so much more fun.

I am a big fan of theatre and Shakespeare so I thought lets combine it and put William Shakespeare greatest and most famous monoloques in the lorum ipsum generator.

ramon-src commented 3 years ago

Hi @Steven24K thanks for sharing your Ipsum! We are really happy that this tool is useful to you, you are the first one to send us a custom Ipsum!

I've notice that in your file, the key is copied by arnold. Please change that to the shakespeare file name (without .md) then I can approve it!

Steven24K commented 3 years ago

Yes now I see it as well. I copied the file from Arnold's ipsum.

I also forgot to change the colors, so I will also pick some custom colors.

Steven24K commented 3 years ago

@ramon-src I changed the key and colors. The key only being used to uniquely identify an ipsum right?

Steven24K commented 3 years ago

@Sena @ramon-src have you got time to review the changes I made and accept my pull request.

I am hope it can go through, cause I am planning to share the Shakespeare ipsum on social media.

So more people will submit there own ipsum in the future.