search

ipta / pulsar-clock-corrections

Distribution point and tools for observatory clock corrections for pulsar timing.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

No integration tests #13

Closed dlakaplan closed 8 months ago

dlakaplan commented 10 months ago

How to know if a PR is valid? Should it maybe be forced to run the GH action (update_clock_corrections.py) with no errors?

aarchiba commented 8 months ago

That would probably do most of the required validation. Won't necessarily help with code changes, but it might.

aarchiba commented 8 months ago

Quick implementation of this. It would be sort of nice to check that the new version doesn't prevent any file from downloading/being included that was previously working, but that's tricky to even define.