search

ipta / pulsar-clock-corrections

Distribution point and tools for observatory clock corrections for pulsar timing.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

tempo PKS file on Sourceforge has out of order entries in the middle #19

Open dlakaplan opened 7 months ago

dlakaplan commented 7 months ago

https://github.com/nanograv/tempo/blob/master/clock/time_pks.dat

Initial entries:

    MJD       PKS-TID  GPS-PKS  NSITE  Date and comments

  44000.0       0.0               2    ATCA
  60000.0       0.0               2    ATCA
  44000.0       0.0               H    JBmk2
  60000.0       0.0               H    JBmk2
  44000.0       0.0               E    MOST
  60000.0       0.0               E    MOST
 44000.00       0.092             7    PKS
 48811.00       2.033             7    080792
 48812.00       2.128             7    090792
aarchiba commented 5 months ago

As these are for different obscodes, it should be possible to ignore them or otherwise handle the situation; PINT's clock file reader can cope if suitably instructed.

aarchiba commented 5 months ago

In fact we do ignore the ones for the wrong observatories. The problem is here:

https://github.com/nanograv/tempo/blob/master/clock/time_pks.dat#L566

MJD 49958 appears both before and after MJD 49959.

This seems like a TEMPO problem.

dlakaplan commented 5 months ago

Yes, I tried to get David N to fix. He said:

I fixed up these files in the Tempo repository.  For WSRT, I cleaned up the lines near the end that were redundant or out of order.  For Parkes, I removed the lines that set the clock offsets to zero for several other telescopes.  (The update went to the Tempo repository on sourceforge, which is still the main repository.  There is a github repository that Paul D somehow syncs to Sourceforge, but there is a delay.)

So maybe it didn't propagate from sourceforge -> GitHub?

aarchiba commented 5 months ago

Hmm. The error is present in the tempo sourceforge repository:

https://sourceforge.net/p/tempo/tempo/ci/master/tree/clock/time_pks.dat?force=True

 49956.00      -2.692             7    270895
 49957.00      -2.760             7    280895
 49958.00      -2.843             7    290895
 49959.00      -2.929             7    290895
 49958.00      -2.830             7    290895
 49977.00       1.119             7    170995
 49978.00       1.183             7    180995