Closed bquinn closed 10 months ago
In #154 I proposed a new property for both SportsML and Sport Schema to accompany @result-effect. I called it @result-effect-key but we can maybe find a better name.
In SportsML we would have to find some way of applying @result-effect and @result-effect-key to the outcome-totals element since @result-effect resides in the statAttributes group, not outcomeTotalsComplexType
Great, I had missed / forgotten that.
Yes I agree that we need a new property and I'd like to try to find something better than result-effect-key - "key" means something else in my mind. maybe result-effect-target?
I see that I had suggested outcome-result-target above. I'm still confused about resulteffect vs outcomeresult, I'll have to go back and study the table in #154 again... maybe we need to include that in some docs somewhere.
covered by #154
We have agreed to go with resultEffectTarget. Implementing in PR #166 . Therefore closing.
We have resultEffect which has "qualification", "promotion", "demotion", but we don't have a way to represent the thing that is being referenced - eg for qualification to a final or to the Champions League, we need a way to link to that entity.
Use cases:
It seems that we will need a new property in SportsML for this! Currently users are overloading the "key" attribute of outcome-result to handle this, but key really should mean something else (the ID of the outcome itself)
New property sport:outcomeResultPhase ? (coming back to this, we're not sure if "phase" makes sense - "champions league 2020" isn't a phase, it's a competition)
Other name ideas... outcomeResultTarget?
So we would have something like...