iptc / sport-schema

The next generation of sports data, based on IPTC’s SportsML and semantic web principles
12 stars 1 forks source link

Represent thing that is qualified for/promoted to/relegated to #163

Closed bquinn closed 10 months ago

bquinn commented 11 months ago

We have resultEffect which has "qualification", "promotion", "demotion", but we don't have a way to represent the thing that is being referenced - eg for qualification to a final or to the Champions League, we need a way to link to that entity.

Use cases:

  1. Arsenal comes 2nd in the Premier League and qualifies for the Champions League
  2. Wimbledon FC comes last in the FA 1st division and is relegated to the 2nd division
  3. Sprinter X comes 2nd in the heat and therefore qualifies for the finals
  4. Baseball Team Y comes 5th in an amateur tournament and therefore "qualifies" for a consolation match where they play against the 6th
  5. A basketball team qualifies for the NBA playoffs
  6. Preliminary golf tournament, winners qualify for the main tournament on the main weekend
  7. F1 driver gets the best time in the practice round and "qualifies" for pole position (could use the "type" field to say "type: ranking" ??)

It seems that we will need a new property in SportsML for this! Currently users are overloading the "key" attribute of outcome-result to handle this, but key really should mean something else (the ID of the outcome itself)

New property sport:outcomeResultPhase ? (coming back to this, we're not sure if "phase" makes sense - "champions league 2020" isn't a phase, it's a competition)

Other name ideas... outcomeResultTarget?

So we would have something like...

<> sport:resultEffect spresulteffect:qualification ;
      sport:outcomeResultPhase <Champions league-2020> .
pauljkelly commented 11 months ago

In #154 I proposed a new property for both SportsML and Sport Schema to accompany @result-effect. I called it @result-effect-key but we can maybe find a better name.

In SportsML we would have to find some way of applying @result-effect and @result-effect-key to the outcome-totals element since @result-effect resides in the statAttributes group, not outcomeTotalsComplexType

bquinn commented 11 months ago

Great, I had missed / forgotten that.

Yes I agree that we need a new property and I'd like to try to find something better than result-effect-key - "key" means something else in my mind. maybe result-effect-target?

I see that I had suggested outcome-result-target above. I'm still confused about resulteffect vs outcomeresult, I'll have to go back and study the table in #154 again... maybe we need to include that in some docs somewhere.

bquinn commented 10 months ago

covered by #154

bquinn commented 10 months ago

We have agreed to go with resultEffectTarget. Implementing in PR #166 . Therefore closing.