iptc / sportsml-3

Development of SportsML 3
9 stars 1 forks source link

Examples use incorrect CV values #50

Closed bquinn closed 5 years ago

bquinn commented 5 years ago

I’ve noticed that the qcodes for name roles and name types in the SportsML example files don’t match the short names used in the SportsJS examples, but also they don’t even match the list of valid newscodes!

The SportsML example files have the following nprt: terms with examples:

<name part="nprt:common">Real Madrid</name>
<name part="nprt:first">Britta</name>
<name part="nprt:last">Kowalczyk</name>
<name part="nprt:nickname">Maple Leafs</name>

And the following nrol: terms, with examples:

<name role="nrol:full">FC Bayern München</name>
<name role="nrol:first">Novak</name>
<name role="nrol:last">Djokovic</name>

Whereas the correct nprt: vocabulary (http://cv.iptc.org/newscodes/namepart/) only has “family”, “given”, “middle” and “salutation”

And the correct nrol: vocabulary (http://cv.iptc.org/newscodes/namerole/) has “full”, “display”, “alternate” and more, but not “first" and "last" or "common".

Also we have two different ways of expressing “first name” and “last name” using “nprt” and “nrol”.

So I think we have two options…

  1. Add the “missing” terms to the namepart and namerole CVs Although that would mean that we have both “first” and “given”, and “last” and “family” which would be weird.

  2. Convert the examples: “nprt:last” and “nrol:last” to “nprt:family” “nprt:first” and “nrol:first” to “nprt:given” “nprt:common” to “nrol:full” “nprt:nickname” to “nrol:alternate”

bquinn commented 5 years ago

In the Sports Content Working Group meeting on 5 February 2019, we decided to go ahead with option 2 above - to change the examples to match the correct CVs.

bquinn commented 5 years ago

Fixed in SportsML 3.1. Closing this issue.