search

iptc / sportsml-3

Development of SportsML 3
9 stars 1 forks source link

Label for career-phase #68

Open pauljkelly opened 1 year ago

pauljkelly commented 1 year ago

These need labels because they are otherwise difficult to distinguish. Example:

<career-phase phase-type="spphase:professional" label="Boston Bruins" phase-caliber="spct:team" key="vendteam:l.nhl.com-BOS" position-regular="spichpos:center" phase-status="spphasestatus:inactive" start-date="1997-06-21" end-date="2005-11-30"/>

Overall, this representation of Joe Thornton's tenure with the Bruins is not up to snuff. The key could be repeated if he returns to the team later in his career and @phase-caliber (do we use en-gb here or not?) is getting shoe-horned.

For now, just add the label but we need to get it right for Sport Schema

bquinn commented 1 year ago

This will be fixed if we generate IDs for memberships including the start-date as well as the team and player IDs.