Refactor tube_manager to a separate file

iptube / SPUDlib

Substrate Protocol for User Datagrams (SPUD) Prototype

BSD 2-Clause "Simplified" License

5 stars 11 forks source link

Refactor tube_manager to a separate file #45

Closed hildjj closed 9 years ago

hildjj commented 9 years ago

Also added support for timers and signals

coveralls commented 9 years ago

Coverage decreased (-9.06%) to 75.16% when pulling a7b2938d2e00579f9182773c6a6c4a59d00b47a4 on timers into cd5bb1a2ff24c3381d3e8d7d85a0164eafafe951 on master.

palerikm commented 9 years ago

Lots of good things in this pull request like moving to sockaddr_storage and so on.

Not sure about using bleeding edge cmake. Mut always nice to test new features if needed.

Timers and signals make up for the decreased test coverage.

hildjj commented 9 years ago

Moving to cmake 3.2 was necessary so that I could use UPDATE_DISCONNECTED; without that, you can't compile on the airplane since cmake will do a 'git pull' every time you make.

palerikm commented 9 years ago

Tested with ubuntu. (Had to install cmake, but really little pain with that).

Merging now. We should update the README.md to better describe why "bleeding edge" cmake is needed.