iptux-src / iptux

A software for sharing in LAN
GNU General Public License v2.0
432 stars 128 forks source link

#609: no extra \U0001 #614

Closed lidaobing closed 1 week ago

lidaobing commented 1 week ago

Summary by Sourcery

This pull request refactors the message sending mechanism to use shared_ptr, introduces new methods in GroupInfo for handling input buffers, and adds a toggle function for URL opening to facilitate testing. It also includes updates to the corresponding tests to reflect these changes.

sourcery-ai[bot] commented 1 week ago

Reviewer's Guide by Sourcery

This pull request refactors the message sending logic to use shared_ptr and moves text buffer handling to GroupInfo. It also introduces an atomic flag to control URL opening and updates corresponding tests. Additionally, it replaces giter_compare_foreach with ig_unichar_is_atomic for character comparison.

File-Level Changes

Files Changes
src/iptux/DialogPeer.cpp
src/iptux/UiModels.cpp
src/iptux/DialogPeer.h
src/iptux/UiModels.h
Refactored message sending logic to use shared_ptr and moved text buffer handling to GroupInfo.
src/iptux/UiHelper.cpp
src/iptux/ApplicationTest.cpp
src/iptux/UiHelper.h
Added atomic flag to control URL opening and corresponding test toggle function.
src/iptux-core/CoreThread.cpp
src/iptux-core/CoreThread.h
src/iptux-core/CoreThreadTest.cpp
Updated CoreThread to use shared_ptr for message sending.
src/iptux-utils/utils.cpp
src/iptux-utils/utils.h
Replaced giter_compare_foreach with ig_unichar_is_atomic for character comparison.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 77.77778% with 12 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (b5581c5) to head (5b9e573).

Files Patch % Lines
src/iptux/DialogPeer.cpp 0.00% 7 Missing :warning:
src/iptux-core/CoreThread.cpp 50.00% 3 Missing :warning:
src/iptux/UiModels.cpp 94.87% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #614 +/- ## ========================================== + Coverage 51.44% 51.85% +0.41% ========================================== Files 64 64 Lines 8361 8370 +9 ========================================== + Hits 4301 4340 +39 + Misses 4060 4030 -30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.