Closed lidaobing closed 1 week ago
This pull request refactors the message sending logic to use shared_ptr
Files | Changes |
---|---|
src/iptux/DialogPeer.cpp src/iptux/UiModels.cpp src/iptux/DialogPeer.h src/iptux/UiModels.h |
Refactored message sending logic to use shared_ptr |
src/iptux/UiHelper.cpp src/iptux/ApplicationTest.cpp src/iptux/UiHelper.h |
Added atomic flag to control URL opening and corresponding test toggle function. |
src/iptux-core/CoreThread.cpp src/iptux-core/CoreThread.h src/iptux-core/CoreThreadTest.cpp |
Updated CoreThread to use shared_ptr |
src/iptux-utils/utils.cpp src/iptux-utils/utils.h |
Replaced giter_compare_foreach with ig_unichar_is_atomic for character comparison. |
Attention: Patch coverage is 77.77778%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 51.85%. Comparing base (
b5581c5
) to head (5b9e573
).
Files | Patch % | Lines |
---|---|---|
src/iptux/DialogPeer.cpp | 0.00% | 7 Missing :warning: |
src/iptux-core/CoreThread.cpp | 50.00% | 3 Missing :warning: |
src/iptux/UiModels.cpp | 94.87% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary by Sourcery
This pull request refactors the message sending mechanism to use shared_ptr, introduces new methods in GroupInfo for handling input buffers, and adds a toggle function for URL opening to facilitate testing. It also includes updates to the corresponding tests to reflect these changes.