ipums / ipumspy

Mozilla Public License 2.0
8 stars 6 forks source link

Add more python versions to test #15

Closed khwilson closed 3 years ago

khwilson commented 3 years ago

Currently, only 3.7 is tested, but we should really also test 3.8, 3.9, and 3.10. This just adds those tests in.

khwilson commented 3 years ago

@renae-r I also realize that the current automated tests are not running the integration tests. Should those be added to the automation?

renae-r commented 3 years ago

Good call on the more recent python versions! Probably a good idea to add the integration tests to the automated workflow - I can't remember a reason that they were excluded.

renae-r commented 3 years ago

oof. that did not work as expected.

renae-r commented 3 years ago

Oh. Now I remember why. But I can fix it.

khwilson commented 3 years ago

Hah! Yeah, I also don't have access to the secrets with my current permissions. Perhaps @franfabrizio should weigh in?

khwilson commented 3 years ago

Oh, sorry, I read can as can't. nvm @franfabrizio sorry for tagging you in!

renae-r commented 3 years ago

tada! I think everything is working now. This looks good to me!

khwilson commented 3 years ago

🙌 :shipit: