search

ipums / ipumspy

Mozilla Public License 2.0
8 stars 6 forks source link

better error messaging around unused kwargs #20

Closed renae-r closed 3 years ago

renae-r commented 3 years ago

Joe pointed out that you can pass a non-usa collection name to UsaExtract() and not get an error, which is fine, but we should probably have a warning or something that clarifies that.

khwilson commented 3 years ago

Perhaps we should just get rid of **kwargs altogether in the __init__ of UsaExtract? They're not actually read by anything.

renae-r commented 3 years ago

Yeah maybe that is the best way to go.

renae-r commented 3 years ago

Removing the **kwargs from UsaExtract breaks the method to read an extract definition from a file. As a possible alternative I left the **kwargs intact and set up a warning for when the user specifies a conflicting collection. See PR #25 (tests currently failing because of the black problem that was solved on another branch : / ).

renae-r commented 3 years ago

fixed issue with rebase from master. Calling this done.