Initial API interaface - Githubissues

ipums / ipumspy

Mozilla Public License 2.0

8 stars 6 forks source link

Initial API interaface #4

Closed khwilson closed 3 years ago

khwilson commented 3 years ago

I think I've put together all the changes that we talked about on Wednesday. Some features:

General structure split into a client (IpumsApiClient) and payloads (BaseExtract)
Subclasses of BaseExtract indicate which collection they reflect (currently only have a CpsExtract example based on Renae's example)
Provide an OtherExtract that allows for non-yet-supported APIs
Provide an example of submit-and-download workflow in the CLI

khwilson commented 3 years ago

@renae-r anything else you want to incorporate into this? Else, do you want to merge?

renae-r commented 3 years ago

@khwilson, my apologies for the delay! This looks good to me and I have nothing else to incorporate at this time. There is some confusion on our end as to who is supposed to be handling PRs. We've got a meeting later today to try and clear some of this up. I will follow up soon!

khwilson commented 3 years ago

Not at all a problem! Just wanted to make sure I hadn't missed any requests for changes. :-)