Allow setting other settings via .env as well

ipunkt / laravel-analytics

Analytics tracking package for Laravel

MIT License

263 stars 54 forks source link

Allow setting other settings via .env as well #33

Closed martijn94 closed 7 years ago

martijn94 commented 8 years ago

Currently only the TrackingID and Proviver can be set via a .env variable.

It would be nice if that would also be possible for the other settings.

rokde commented 8 years ago

Tracking ID setting should not change in live code. And Provider is the basis for creation in Service Provider. So when you need a different provider simply use your own provider to instantiate or add a factory or manager pattern on your own. We will not implement this behaviour. Sorry.

martijn94 commented 8 years ago

Hi Robert,

I think you misunderstood my question. Currently the only settings that can be set via .env are ANALYTICS_TRACKING_ID and ANALYTICS_PROVIDER.

I would love to see the ability to set display_features, anonymize_ip, auto_track and debug options via .env as well.

rokde commented 8 years ago

Okay, I misunderstood you, that's right.

WaveHack commented 7 years ago

This should be fixed by now due to PR https://github.com/ipunkt/laravel-analytics/pull/39

rokde commented 7 years ago

Release 1.3.2 solves this issue.