ipup / PPRevealSideViewController

A new container controller to easily push views on side like Path or Facebook
www.ipup.pro
Other
821 stars 194 forks source link

Bug with iOS 7: PPRevealSideView ignores Status Bar. #72

Closed MarcoSpeziali closed 10 years ago

MarcoSpeziali commented 11 years ago

Here's a screen shot: By the way, I checked, and the Status Bar isn't hidden.

bugs

ipodishima commented 11 years ago

Hi

Yes, I haven't start debugging yet on iOS 7, since we are on the pre release and regressions from Apple are still presents. But, we will have issues in the future I think, since the status bar is translucent on iOS 7. So stay in touch, this will be fixed but not now, I'm waiting for the golden master to fix these kinds of things. In the meantime, feel free to provide any temp fix. I just won't start digging until the last version of iOS 7

MarcoSpeziali commented 11 years ago

Ok, thank you anyway!

amau96 commented 11 years ago

any news about it?

MarcoSpeziali commented 11 years ago

Unfortunately not... I believe that it's actually an Xcode bug: In Xcode 4.* when you set your view at position x: 0, Y: 0 automatically sets your view 20px (status bar height) below, but in Xcode 5 that doesn't seem to happen. And even if you manually set your view 20px below the result it's really weird: untitled

So I think it's an Xcode bug, many people reported to Apple other related bugs.

georgbachmann commented 11 years ago

Try out the "Extended Edges" properties in InterfaceBuilder. It's in the attributes inspector for the selected ViewController. Uncheck the "Under Top Bars" and the 20px issue is gone.

What remains is that the backgroundColor of my window is black and therefore the statusbar is black and I didn't find a quick solution for fixing this right now. So I guess I also wait for the GM to really try to fix this...

amau96 commented 11 years ago

Ok, 7 days before IOS7, anyone can try to fix this?

MarcoSpeziali commented 11 years ago

My last attempt was made with Xcode 5 DP (Developer Preview) 5 and there aren't newer versions though there's a newer iOS 7 Beta version (iOS 7 Beta 6)! So we have to wait until the official release of iOS 7 and Xcode 5. We do not have much of a hurry because unless you publish your "iOS7-built" app you won't have these problems (maybe some unavailable methods that will crash your app). I tried to install on my iOS 7 device all of my "iOS6-built" app and they works fine! But in my opinion the final release will fix all this graphic-related problems!

amau96 commented 11 years ago

The final version (gold master) is available for ios7 and Xcode since yesterday.

MarcoSpeziali commented 11 years ago

Gosh, really? Apple didn't notify me! Did you try to compile the PPRevealSideViewController Demo?

MarcoSpeziali commented 11 years ago

Yes, the demo as is doesn't work, as usual (talking about iOS 7 tests)... 1

I noticed one thing: If you take an iOS 6 xib and you compare it with the iOS 7 one the main difference is that in the second one only the "sides-attached controls" (e.g. Navigation Bar, Tab Bar) don't care about the status bar but the others do. So we might need to implement some macros that let us think in the previous way ("I don't care about the status bar") such as #define OldCGPoint(x, y) CGPointMake(x, y + kStatusBarHeight)! But I'm not going to touch other's code! So the hard work is up to the developers of this control!

MarcoSpeziali commented 11 years ago

I dint't mean to close the issue! Ops

amau96 commented 11 years ago

@ipodishima any news about a fix ?

ipodishima commented 11 years ago

I really don't have the time right now to look into it, nor the ability to download the latest version of Xcode. Will get to it asap

MeTazz1 commented 11 years ago

By now, one thing you can do is to re-set the frame of your appDelegate.window(0, 20, window.width, window.height) and add a background image or color to your main window ( (0, 0, window.width, 20). And don't forget :

    [[UIApplication sharedApplication] setStatusBarStyle:UIStatusBarStyleLightContent];

Here is the result of those lines

screen shot 2013-09-18 at 11 35 18 pm

ipodishima commented 11 years ago

Hi there

Just to let you know that I made a fix for iOS 7. Is that what you wanted? I Have to say that the table view doesn't go below the status bar.

image

amau96 commented 11 years ago

Can you commit your fix? Or give us the code?

ipodishima commented 11 years ago

Please check the other branch I created for that. The fix is online but not in master branch

amau96 commented 11 years ago

doesn't seem to work, but maybe there is a fix to do with IB too ...

I still have the black bar like the one in the first screen shot in the front view

ipodishima commented 11 years ago

That's weird. Please first test the sample and tell me that this is the right behavior or not. Then you will be able to track your issue but I can't do both because I don't know your project. Maybe that you're using an image for navigation bar?

amau96 commented 11 years ago

your are right ! the probleme came from the image for the navigation bar :)

apoca commented 11 years ago

// Line changed rect.size.height -= PPSystemVersionGreaterOrEqualThan(7.0) ? 0.0: PPStatusBarHeight();

captura de ecra 2013-10-3 as 23 37 03