Moving status bar on iOS 7

[cvknage]

Hi, I made a modefication to your side menu, that I think improves the look and feel when using it on iOS 7. The idea is to move the status bar with the rootViewController when opening and closing the side menu. This idea pretty common around the internet by now, but I would like to see it implemented in PPRevealSideViewController.

I have implemented this feature in two different ways, and would like to hear your opinion on which you think is better.

1) REAL_STATUS_BAR == 1 Uses Apple private API to access the statusBar property and move its frame around.

• Advantage: Actually moving the status bar so time, battery & cell/WiFi strength will always appear correctly.
• Disadvantage: Is of course the use of private Apple API which may not be permitted in the AppStore.
• Info: I suspect the App Interesting in AppStore may use some similar code.

2) REAL_STATUS_BAR == 0 Uses “snapshotViewAfterScreenUpdates:” to add an image on the navigation bar and hide the real status bar.

• Advantage: Does not use any private Apple API so no problems with AppStore.
• Disadvantage: The status bar is "replaces" by a screen shot when the side menu is open.
• Info: I suspect the App Mailbox in AppStore may use some similar code.

This is my first pull request on GitHub, so I am not 100% sure if I am approaching this correctly. I know that having both implementations may nit be desirable, so I would like to implement just the one of the two options you like better and make another pull request. Also I was thinking of making it optional, but I wanted to hear if you where interested in this at all before proceeding further.

[ipodishima]

Hi

Thanks for you pull request. I will get to you asap

[ipodishima]

Hi

I didn't used your PR, but took a lot of your ideas for the integration. You now have two options (Fading or Moving), see the ReadMe

Thanks again, you are in the short list of the contributors!

[ipodishima]

Please note that you should do

[self.revealSideViewController resetOption:PPRevealSideOptionsiOS7StatusBarFading];
[self.revealSideViewController setOption:PPRevealSideOptionsiOS7StatusBarMoving];

[cvknage]

Cool :-) There seems to be some bugs in the latest (1.1.0) version though.

Moving side menu issues: The moving side menu isn't reset when the side menu is closed. This results in the status bar showing as doubled when the time changes, you enable/disable bluetooth or some thing similar. This of course is expected when the side menu is open, but when the side menu closes the screenshot view should be reset, so we only show the real status bar, and can get a new screenshot when the side menu is opened again.

Fading side menu issues: The view in the side menu is moved down 20 pixel when the status bar opens, this is really problematic as the bottom 20 pixel of a static side menu will be pushed out of the screen.

[ipodishima]

Yes I saw a few bugs with sliding status bar. Will investigate this week

[ipodishima]

So. I spend my morning working on that. The first point is really easy, there is a removeFromSuperview missing. The second point, can't see it. But: there is an other issue i'm affraid: with moving side menu, open on left, then hit to place a new center controller. There are layout issues because the status bar is hidden, so the new center with nav bar is not well adjusted. I tried several things with no luck. If you have any idea, be welcome

[cvknage]

Let me get back to you on the center controller layout issues on moving statusbar. I will play around with it this evening and see what I can do :-) EDIT Sorry I havn't gotten back to you guys, there is just a lot going on at the moment.. END EDIT

The Fading side menu issues: When using version 1.1.0 the side menu view is pushed down 20 pixel. The following images show the difference between version 1.0.1 & 1.1.0 I set: fakeiOS7StatusBarColor = [UIColor clearColor]; to better show the effect. (Edited App Images to prevent showing off product names)

version 1.0.1 (As expected) version 1.1.0 (Side menu is moved down by 20 pixel)