search

ipython-contrib / jupyter_contrib_nbextensions

A collection of various notebook extensions for Jupyter
http://jupyter-contrib-nbextensions.readthedocs.io/en/latest
Other
5.22k stars 806 forks source link

zenmode: not working properly with jupyter themes #1461

Closed luckylsk34 closed 1 year ago

luckylsk34 commented 4 years ago

Hello there,

Toggling zenmode off while using jupyter themes doesn't restore the previous background and CSS properties. As a result, the following happens.

before using zenmode: Screenshot_2019-09-28 Untitled

toggling zenmode on: Screenshot_2019-09-28 Untitled(1)

toggling zenmode off: Screenshot_2019-09-28 Untitled(2)

Toggling zenmode off is expected to revert to the first image but as it shows in the third image, it does not. I am not using any URLs for background images, my "Use builtin backgrounds in addition to any specified by URL" is checked OFF in zenmode settings. The grey background around the code cell also stands out from the body's background.

luckylsk34 commented 4 years ago

Maybe we can leave the background as is when no images or urls are used.

luckylsk34 commented 1 year ago

Closed by #1462 .