search

ipython-contrib / jupyter_contrib_nbextensions

A collection of various notebook extensions for Jupyter
http://jupyter-contrib-nbextensions.readthedocs.io/en/latest
Other
5.2k stars 805 forks source link

Fix syntax error in snippets_menu pandas.js that breaks SnippetsMenu #1636

Open sjdemartini opened 1 year ago

sjdemartini commented 1 year ago

There was a syntax error introduced to the pandas snippets in commit d0fb8668c1158fd17a803ebd3fda0b01014b7021, since it attempted to use single quotes within a single-quoted string.

Without this fix, the Snippets menu would entirely fail to load if the built-in Pandas snippets are included (as is the default), with the dev tools console reporting Uncaught SyntaxError: Unexpected identifier 'label_count' (at pandas.js?v=20230413134100:119:39) 13:49:07.959. This should resolve the problem and ensure that the default SnippetsMenu works again, and that pandas snippets can be included.

As a workaround until this is merged and published, for anyone who comes across this, you can uncheck the "Include pandas sub-menu" option for Snippets Menu in the Nbextensions UI, or equivalently set "snippets": {"include_submenu": { "pandas": false, } } within your nbconfig file (which can be found at echo $(jupyter --config-dir)/nbconfig/notebook.json).

yonghaoy commented 9 months ago

Also for encountered this issue. Any ETA on when this can be fixed? Also thank @sjdemartini for providing this walkaround

yonghaoy commented 9 months ago

@jcb91 for review?