search

ipython-contrib / jupyter_contrib_nbextensions

A collection of various notebook extensions for Jupyter
http://jupyter-contrib-nbextensions.readthedocs.io/en/latest
Other
5.24k stars 807 forks source link

FontAwesome icons depracated and need updating #187

Closed zach-hartwig closed 9 years ago

zach-hartwig commented 9 years ago

Hello,

I've just cloned the most recent commit. I'm using the 'hide_input_all.js' and 'read-only.js' extensions, which work great. However, the icons for these extensions show up blank on my IPython Notebook It appears that the icon names need to be updated to FontAwesome4.2.0. For example, in 'read-only'.js, the current code attempts to specify a lock icon with:

icon : 'icon-lock',

when for FontAwesome 4.2.0 it should be

icon : 'fa-lock',

Making this change gets the icon working perfectly. I only use these two icon-based extensions presently, but, in general, all icons may need updating.

juhasch commented 9 years ago

Yes, this has been changed in IPython. Can you make a pull request with the required changes ?