search

ipython / comm

Python Comm implementation for the Jupyter kernel protocol
BSD 3-Clause "New" or "Revised" License
9 stars 15 forks source link

Remove dep on traitlet #15

Open vincent-grosbois opened 1 year ago

vincent-grosbois commented 1 year ago

Hi! as we discovered, the dependency on traitlet >= 5 means that actually, the comm project requires python >= 3.7 contrary to what is published (claims to support python 3.6)

I've seen that the traitlet dependency is used just in order to import this : https://github.com/ipython/traitlets/blob/main/traitlets/utils/importstring.py , which is pretty stable and easy

I suggest to just copy the method in comm package and remove the dep on traitlet all-together what do you think ?

vincent-grosbois commented 1 year ago

Or otherwise, if it's simpler, we can losen the dependency as you suggested : https://github.com/ipython/comm/pull/16

martinRenou commented 1 year ago

Thank you for doing this, I triggered the release it should come soon.

Concerning the removal of traitlets, we may want to consider this later indeed.