search

ipython / ipykernel

IPython Kernel for Jupyter
https://ipykernel.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
653 stars 368 forks source link

Explicitly close memory object streams #1253

Closed ianthomas23 closed 4 months ago

ianthomas23 commented 5 months ago

Fixes #1252.

When using anyio MemoryObjectReceiveStream and MemoryObjectSendStream we must explicitly close them when we have finished with them. This wasn't necessary with anyio 4.3.0 but is with 4.4.0 as otherwise warnings/errors are issued which break our CI.

This is only actually an issue in CI as our only explicit use of memory object streams is in TestSession.

ianthomas23 commented 4 months ago

This fixes all the local CI runs, except the docs which is some other problem. I am self-merging.