search

ipython / ipykernel

IPython Kernel for Jupyter
https://ipykernel.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
653 stars 368 forks source link

Improve robustness of subshell concurrency tests using Barrier #1288

Closed ianthomas23 closed 2 weeks ago

ianthomas23 commented 3 weeks ago

Second attempt to improve robustness of subshell concurrency tests, building on #1285. Using a threading.Barrier at start of subshell code execution in tests that are sensitive to timing so that they are tolerant of, for example, a shell message that takes slightly longer to send/receive than normal.

I am hoping to fix ipython/ipython#14545 eventually.

ianthomas23 commented 3 weeks ago

+1, should we merge as is ?

Yes please, and I can iterate further if necessary.