ipython / ipynb

Package / Module importer for importing code from Jupyter Notebook files (.ipynb)
https://ipynb.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
245 stars 70 forks source link

IndentationError: unexpected indent #29

Open xgdgsc opened 7 years ago

xgdgsc commented 7 years ago

When using import ipynb.fs.defs.myipynb, I get an error:

 File "<unknown>", line 81
    alpha_dict[key] = alpha_dict[key].ewm(span=20,adjust=True,min_periods=0,ignore_na=False).mean()
    ^
IndentationError: unexpected indent

The cell is:

for key in alpha_dict:
    alpha_dict[key] = alpha_dict[key].ewm(span=20,adjust=True,min_periods=0,ignore_na=False).mean()

I don' t know why would it try to import a for loop like this.

AEDWIP commented 7 years ago

I ran into a similar problem. In my case the cell above was markdown and the the last line in the cell was part of an indented list. The first line of the code cell started with 'def'

Adding an extra new line on the bottom of the markdown fixed the problem.

hard to believe its a parsing error given the implementation of ipynb uses the abstract syntax tree.

alexlouden commented 7 years ago

I had a markdown cell with no trailing newline and the first line of the following cell wasn't being executed - looks like the same issue.

I was able to reproduce here: https://gist.github.com/alexlouden/4d8cae9643b9118e4c3c23d0b44e12d7

You can see that only Line2 is printed by notebook2

yuvipanda commented 7 years ago

I'm considering getting rid of the 'defs' feature completely, since I am unsure if we can ever implement it in a way that's consistent and safe in all cases...

Would you all be able to use the 'full' import without problems?

alexlouden commented 7 years ago

I was actually using full - see my gist above (using the latest PyPi release - ipynb==0.4)

alexlouden commented 7 years ago

Just tried version 0.5 from Github and looks like it's fixed - thanks!

Releasing it to PyPi would be great, if you can?

yuvipanda commented 7 years ago

I just released to pypi! Can you test?

On Sun, Oct 22, 2017 at 11:16 PM, Alex Louden notifications@github.com wrote:

Just tried version 0.5 from Github and looks like it's fixed - thanks!

Releasing it to PyPi https://github.com/ipython/ipynb/issues/26 would be great, if you can?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ipython/ipynb/issues/29#issuecomment-338557831, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB23hSdXfnRyooMCPObQ3zLtJ_3i7QXks5svC8ygaJpZM4MdlsS .

-- Yuvi Panda T http://yuvi.in/blog

alexlouden commented 7 years ago

It's working, thanks!

❯ pip install ipynb
Collecting ipynb
  Downloading ipynb-0.5.1-py3-none-any.whl
Installing collected packages: ipynb
Successfully installed ipynb-0.5.1