search

ipython / ipython_genutils

Vestigial IPython utilities: DO NOT USE
Other
11 stars 22 forks source link

treat strings under ironpthon 2.7 as unicode, like 3.x #6

Closed swn1 closed 8 years ago

swn1 commented 8 years ago

Issue #5 . The diff listing fails to make clear the structure of the change: all of the unicode/byte conversion assignments were broken out of the if/else PY3 clauses and a new conditional was inserted just for them, with PY3 or IronPython as the if branch. The assignments themselves are unchanged, just the logic selecting which set is in force changed.

swn1 commented 8 years ago

I should add that I am not completely certain the new logic is capital-R Right, it does what I needed it to do in jupyter_client and should be safe anywhere platform.python_implementation exists and returns something reasonable.

takluyver commented 8 years ago

Looks OK to me. I'll give @minrk a chance to see it before merging.

minrk commented 8 years ago

Fine by me. Though we should be clear that this package is entirely deprecated, and for the most part any case it doesn't yet cover should result in adopting standard tools like six, backports, etc. where available. So while this may fix it for now, all use of this package will eventually be removed from all Jupyter and IPython projects.