search

iqbal-lab-org / gramtools

Genome inference from a population reference graph
MIT License
92 stars 15 forks source link

Fails to map/match to a PRG with no variation #27

Closed iqbal-lab closed 8 years ago

iqbal-lab commented 8 years ago

Just reinstated the unit tests with 1byte and 100a's, both with no variation. In both cases, all reads/strings fail to match

Commit: 32b286fe20fa8ce37a09a43ca56cb1dfcb9c5db4

./unittest_bidir_search_bwd_fwd [==========] Running 9 tests from 1 test case. [----------] Global test environment set-up. [----------] 9 tests from BackwardSearchTest [ RUN ] BackwardSearchTest.NoVariants1 PRG size: 1 Alphabet size: 0 ./test/unittest_bidir_search_bwd_fwd.cpp:76: Failure Value of: occ_expt Actual: 0 Expected: no_occ Which is: 1 PRG size: 1 Alphabet size: 0 ./test/unittest_bidir_search_bwd_fwd.cpp:89: Failure Value of: occ_expt Actual: 0 Expected: no_occ Which is: 1 [ FAILED ] BackwardSearchTest.NoVariants1 (1663 ms) [ RUN ] BackwardSearchTest.NoVariants2 PRG size: 100 Alphabet size: 0 ./test/unittest_bidir_search_bwd_fwd.cpp:152: Failure Value of: occ_expt Actual: 0 Expected: no_occ Which is: 100 ... etc

iqbal-lab commented 8 years ago

Fixed: rookie mistake commit: 16593d6ec1bfa8cb998dd802bfd3983a00f36297

I took the liberty of changing the test with 100a's to 36a's because I'd prefer a unit test that doesn't take 1000 years to run - @sm0179 let me know if thats ok with you.