search

iqbal-lab-org / gramtools

Genome inference from a population reference graph
MIT License
92 stars 15 forks source link

TwoSNPs unit tests shows sites object storing same site-id for both SNPs #30

Closed iqbal-lab closed 8 years ago

iqbal-lab commented 8 years ago

At this commit

commit 1c0bcdc5fcb0de9c94701a9679dfaa9e75997a99 Author: Zamin Iqbal zam@well.ox.ac.uk Date: Sun Jul 31 21:57:32 2016 +0100

Add check of sites object in TwoSNPs unit test - FAILS.

[ RUN      ] BackwardSearchTest.TwoSNPs
./test/unittest_bidir_search_bwd_fwd.cpp:202: Failure
Value of: 5
Expected: sites.back().front().first
Which is: 7
[  FAILED  ] BackwardSearchTest.TwoSNPs (522 ms)

Seems to have same site-id for both SNPs it crosses  in
the sites object
iqbal-lab commented 8 years ago

Apologies, my fault, error in test code, got lost in layers of lists of vectors of.. etc. Fixed in 28a7f53b8c59450746125da551aaddd35e72ea05