iqbal-lab-org / make_prg

Code to create a PRG from a Multiple Sequence Alignment file
Other
21 stars 7 forks source link

make_prg update PR series: 6. Add sample example and update tests #40

Closed leoisl closed 1 year ago

leoisl commented 1 year ago

@mbhall88 sorry for being pre-emptive here, but I am merging this PR directly. This PR just adds the sample example and update make_prg tests (code and data). I think it is somewhat unreviewable, with 190 changed files, 2,190 additions and 54 deletions, but it is just the nature of such PR that adds sample example and update tests.

The sample example part is easy to justify why we would need it.

The tests I think is safe to merge because:

  1. We have 325 new tests (from 116 to 441 total tests), with test coverage >99% in non-argument parsing code;
  2. We have 44 integration tests testing the whole code, 33 for make_prg from_msa command and 11 for make_prg update command;

Please tell me in the future if I should not do this and all PRs should be peer-reviewed with no exceptions.

iqbal-lab commented 1 year ago

this is fine leandro!

mbhall88 commented 1 year ago

agreed, this is fine