Closed leoisl closed 1 year ago
does this explain that SNP thing @leoisl ?
yep! although it would be interesting to check the impact of this change on the 20-way dataset... I think we should test new make_prg + new pandora releases on both 20-way and drprg...
This PR makes it explicit the priority of which node we build in
NodeFactory.build()
. This is important to prioritise which types of nodes we try to build first. This priority directly translates to how we partition the MSA in the recursive clustering and collapse algorithm, so it is at the core of themake_prg
algorithm. In summary, we try to first build a leaf if we can, as if we can build a leaf, there is no need to recursively partition the MSA horizontally or vertically. If that does not work, we try to build a multi interval node, i.e. try to partition the MSA vertically. If that does not work, we try to build a multi cluster node, i.e. try to partition the MSA horizontally. If that does not work, then it means we can't partition the MSA anymore, then we force build a leaf. We have a corner case when building the root, which is slightly different. In more details this is the node building priority we apply:Several unit tests were added, and two integration tests validating the sample example were added.
Closes #43