search

iqbal-lab-org / make_prg

Code to create a PRG from a Multiple Sequence Alignment file
Other
21 stars 7 forks source link

Embed mafft into make_prg #52

Closed leoisl closed 1 year ago

leoisl commented 1 year ago

Now we have no non-python dependencies anymore. We don't need to have mafft to run update integration tests, nor to run the sample example. The precompiled binary and installation through pip are now self contained. conda and containers don't need to install mafft anymore, but that is a very minor improvement to these installation processes, as it is quite easy to install mafft in a conda or in a container. Removed --mafft parameter from make_prg update subcommand.

Closes #50

iqbal-lab commented 1 year ago

But you approve pessimistically? Or not approve?

leoisl commented 1 year ago

I leave to both of you the decision to accept or reject this PR! Any decision is totally fine by me!

mbhall88 commented 1 year ago

I approve pessimistically 😆

leoisl commented 1 year ago

I think this means I can merge and release, doing it!