iqbal-lab / Mykrobe-predictor

Antibiotic resistance predictions in minutes on a laptop
Other
50 stars 19 forks source link

Ensuring probes do not extend too far #111

Closed iqbal-lab closed 5 years ago

iqbal-lab commented 7 years ago

Probes for SNPs/indels should not extend beyond the variant - all kmers should overlap the variant. Otherwise, you add coverage to both alleles from shared flanks. Not a massive deal for illumina (although why add pointless noise) but I think would be a bigger issue for nanopore data when we already have enough problems without adding to them.

That said, I'm sure I have seen/mostly see things where one allele has covg 0. So probes can't be always 63, as Phelim speculated today.

ie maybe there is no issue here

Phelimb commented 5 years ago

Fixed in https://github.com/Mykrobe-tools/mykrobe