search

iqbal-lab / Mykrobe-predictor

Antibiotic resistance predictions in minutes on a laptop
Other
50 stars 19 forks source link

TB progress output mixed with JSON #20

Closed iqbal-lab closed 9 years ago

iqbal-lab commented 9 years ago

From Simon

"The TB version needs to flush the last Progress to stdout before sending the JSON, at the moment the JSON is being sent with the Progress"

iqbal-lab commented 9 years ago

I have no idea how this can be true

Phelimb commented 9 years ago

I think he means that the JSON output is not valid JSON as there's a bunch or progress lines above it.

i.e. he wants the output to start with { not to have to parse through strings to find the JSON start bracket.

iqbal-lab commented 9 years ago

Fixed in this commit

commit 28b05ec27034faaf30c2399d5dec1bebd8ccd3a4 Author: Zam Iqbal (on laptop) zam@well.ox.ac.uk Date: Wed Oct 15 15:55:56 2014 +0100

Fix flushing to stdout, was possible to get progress info at same time as JSON
iqbal-lab commented 9 years ago

Reopening, Simon says it seemed fixed but is in fact not.

iqbal-lab commented 9 years ago

Fixed by commit: 2443793f0fc04bf84203b2a504bad6caa41e3170