search

iqbal-lab / Mykrobe-predictor

Antibiotic resistance predictions in minutes on a laptop
Other
50 stars 19 forks source link

Windows build #52

Closed Phelimb closed 9 years ago

Phelimb commented 9 years ago

Windows build now working on linux and windows. Thought I'd do a formal pull request rather than just merging.

Phelimb commented 9 years ago

@iqbal-lab did you have to make any changes to libs get Myrkobe to compile on mac ?

My version is broken if I recompile the libs.

iqbal-lab commented 9 years ago

Ah feck. I've just copied a tar.gz called libs.mac.tgz to the PhelimBradley dropbox. You could diff? This is why it needs to be in git. I think the only change is here

libs/seq_file/new_api/Makefile

which has this

tools: htslib cd tools; make HTSLIB=/Users/zam/dev/git/myKrobe-predictor/libs/htslib/ benchmarks: htslib cd benchmarks; make HTSLIB=/Users/zam/dev/git/myKrobe-predictor/libs/htslib/ dev: htslib cd dev; make HTSLIB=/Users/zam/dev/git/myKrobe-predictor/lib\

Sorry, awful

On 24 March 2015 at 14:40, Phelim Bradley notifications@github.com wrote:

@iqbal-lab https://github.com/iqbal-lab did you have to make any changes to libs get Myrkobe to compile on mac ?

My version is broken if I recompile the libs.

— Reply to this email directly or view it on GitHub https://github.com/iqbal-lab/Mykrobe-predictor/pull/52#issuecomment-85532823 .

Phelimb commented 9 years ago

OK, now working on mac + linux + windows I believe.

iqbal-lab commented 9 years ago

hurrah!

On 24 March 2015 at 16:18, Phelim Bradley notifications@github.com wrote:

OK, now working on mac + linux + windows I believe.

— Reply to this email directly or view it on GitHub https://github.com/iqbal-lab/Mykrobe-predictor/pull/52#issuecomment-85587042 .

iqbal-lab commented 9 years ago

is that all rolled into the pull request then?

On 24 March 2015 at 16:19, Zamin Iqbal zam.iqbal.lab@gmail.com wrote:

hurrah!

On 24 March 2015 at 16:18, Phelim Bradley notifications@github.com wrote:

OK, now working on mac + linux + windows I believe.

— Reply to this email directly or view it on GitHub https://github.com/iqbal-lab/Mykrobe-predictor/pull/52#issuecomment-85587042 .

Phelimb commented 9 years ago

Yes, should be.

huangbilly commented 9 years ago

Hi Phelim,

So now the windows compiles fine, should we integrate the nodescript app to work on both? The app should work "out of the box"...

Bill On 24 Mar 2015 16:19, "Zamin Iqbal" notifications@github.com wrote:

hurrah!

On 24 March 2015 at 16:18, Phelim Bradley notifications@github.com wrote:

OK, now working on mac + linux + windows I believe.

— Reply to this email directly or view it on GitHub < https://github.com/iqbal-lab/Mykrobe-predictor/pull/52#issuecomment-85587042

.

— Reply to this email directly or view it on GitHub https://github.com/iqbal-lab/Mykrobe-predictor/pull/52#issuecomment-85587266 .

Phelimb commented 9 years ago

Yes, this would be good. I've got it working on MAC before (although it doesn't seem to be working now). Did you say you had it working on windows? Did you have to make many mods?

huangbilly commented 9 years ago

Yes I got it working on working on windows with very superficial mods. I was thinking you would want a simple file which installs everything for easy setup for the reviewers .. On 24 Mar 2015 16:38, "Phelim Bradley" notifications@github.com wrote:

Yes, this would be good. I've got it working on MAC before (although it doesn't seem to be working now). Did you say you had it working on windows? Did you have to make many mods?

— Reply to this email directly or view it on GitHub https://github.com/iqbal-lab/Mykrobe-predictor/pull/52#issuecomment-85591404 .

iqbal-lab commented 9 years ago

The idea is reviewers just get a .exe for Windows or .dmg for Mac, or actual source for Linux