iqbal-lab / Mykrobe-predictor

Antibiotic resistance predictions in minutes on a laptop
Other
50 stars 19 forks source link

allow amplicon data #87

Closed stephenturner closed 8 years ago

stephenturner commented 8 years ago

When using amplicon data the GUI errors out because the probes used to detect M. tb may not be present. The Linux version can be hacked to work by changing src/predictor/tb/main.c from if (!is_MTBC_present(species_info)) to if(0) and compile with make TB=1 predictor. This would be better as an option to disable checking, and even better if the option were implemented in the GUI.

iqbal-lab commented 8 years ago

Phelim will have a think about whether/how we want to support this Stephen.

Phelimb commented 8 years ago

Possible way is a -f --force option which forces resistance prediction even when species is not TB?

Phelimb commented 8 years ago

GUI will be trickier - perhaps default if not TB should be to go to the species page with a warning that resistance predictions could be incorrect because we don't think the species is TB but allow the user to proceed at their own risk ?

iqbal-lab commented 8 years ago

Or don't support GUI for amplicons.

stephenturner commented 8 years ago

How about a "proceed at your own risk" warning :)

Stephen

On Wed, Sep 23, 2015 at 4:32 PM, Zamin Iqbal notifications@github.com wrote:

Or don't support GUI for amplicons.

— Reply to this email directly or view it on GitHub https://github.com/iqbal-lab/Mykrobe-predictor/issues/87#issuecomment-142720246 .