search

iqbal-lab / Mykrobe-predictor

Antibiotic resistance predictions in minutes on a laptop
Other
50 stars 19 forks source link

Possible floating point error when calculating DFR* thresholds #98

Closed Phelimb closed 8 years ago

Phelimb commented 8 years ago

Should return r if > 0.03 but returns S if < 0.035.

Phelimb commented 8 years ago

Actually problem here was a small bug causing trim to use 0.04 as threshold (BlaZ's) instead of 0.03.

iqbal-lab commented 8 years ago

How did you spot this btw ?

Phelimb commented 8 years ago

I got an email from a user who spotted two inconsistent samples.

iqbal-lab commented 8 years ago

Great!