I'm not crazy about the advice approach at all, but your particular one is also based on outdated information. Company's popup doesn't use display anymore, we settled on 'before-string. That's how the kind icons are able to be rendered, too.
So the end of the advice should be changed.
You can also try advicing company-fill-propertize instead (with an after advice), that should allow a much shorter definition.
I'm not crazy about the advice approach at all, but your particular one is also based on outdated information. Company's popup doesn't use
displayanymore, we settled on'before-string. That's how the kind icons are able to be rendered, too.So the end of the advice should be changed.
You can also try advicing
company-fill-propertizeinstead (with anafteradvice), that should allow a much shorter definition.