search

iqbalansari / restart-emacs

A simple emacs package to restart emacs from within emacs
GNU General Public License v3.0
154 stars 14 forks source link

Name collision in emacs 29 #23

Open thanhvg opened 2 years ago

thanhvg commented 2 years ago

Recent change in emacs 29 dev introduced the same function restart-emacs with fewer features than the one provided in this package. https://github.com/emacs-mirror/emacs/commit/5be9a9cacfaae1959c4b95c45c146044a181ad20 https://github.com/emacs-mirror/emacs/blob/master/lisp/files.el#L7848

So I guess this package must pick up a new function name to be compatible with future emacs?

Thanks

dalanicolai commented 2 years ago

I think users of this package probably prefer to use the restart-emacs function from this package, and don't want to end up with two different restart-emacs functions. So I think this package should just (require 'files) at the beginning of the file, so that the restart-emacs function of this package gets loaded after the restart-emacs of version 29.