search

iqlusioninc / abscissa

Application microframework with command-line option parsing, configuration, error handling, logging, and shell interactions
Apache License 2.0
573 stars 39 forks source link

fix: uses default info if RUST_LOG is not set #863

Closed simonsan closed 8 months ago

simonsan commented 8 months ago

Closes https://github.com/iqlusioninc/abscissa/issues/862

tony-iqlusion commented 8 months ago

It seems like this doesn't actually handle the case of RUST_LOG being set but empty anymore, although I'm not sure that's actually important.

I'm also kind of surprised that clippy doesn't complain about the the use of unwrap_or over unwrap_or_else and it unconditionally allocating the "info" string regardless of if it's needed. But if it's fine with it, so am I.