Hey @sampocs -- could definitely use your review here.
1) some of your changes may not be well represented
2) I think that with the completion of ics for 47, we may want to 47ify the main branch
Here's the basic flow:
noticed that you'd updated the third_party/cosmos folder
eliminated it entirely instead of bringing in your changes
I had questions about GetAllParams instead of GetParams, and I went with the existing code, but we can cherry pick or check out your changes later
Opinion:
I think that we can develop this more easily and with less chance of error using the sdk 47 buf imports. This way we can focus on code that clearly lives here, and also we can push forward with 47 across the ecosystem. I have a concern if we were to do this with 46 anywhere, which is increasing the complexity of upgrades in ways that could be BadTM.
Hey @sampocs -- could definitely use your review here.
1) some of your changes may not be well represented 2) I think that with the completion of ics for 47, we may want to 47ify the main branch
Here's the basic flow:
Opinion:
I think that we can develop this more easily and with less chance of error using the sdk 47 buf imports. This way we can focus on code that clearly lives here, and also we can push forward with 47 across the ecosystem. I have a concern if we were to do this with 46 anywhere, which is increasing the complexity of upgrades in ways that could be BadTM.
wdyt?