iqlusioninc / liquidity-staking-module

Other
87 stars 29 forks source link

Merge main to 47 #74

Closed faddat closed 1 year ago

faddat commented 1 year ago

Hey @sampocs -- could definitely use your review here.

1) some of your changes may not be well represented 2) I think that with the completion of ics for 47, we may want to 47ify the main branch

Here's the basic flow:

Opinion:

I think that we can develop this more easily and with less chance of error using the sdk 47 buf imports. This way we can focus on code that clearly lives here, and also we can push forward with 47 across the ecosystem. I have a concern if we were to do this with 46 anywhere, which is increasing the complexity of upgrades in ways that could be BadTM.

wdyt?

faddat commented 1 year ago

@sampocs just noticed there are some tests that are exploding I am going to mark this as draft till those are cleaned up.

faddat commented 1 year ago

I think that the issue here is a somewhat botched merge. Will return to unbotch soon.