[unitaryhack] Adding a post_build method to Element to avoid calls to super().build() when constructing chips.

iqm-finland / KQCircuits

KLayout Python library for integrated quantum circuit design.

GNU General Public License v3.0

128 stars 71 forks source link

Closed upsideon closed 2 years ago

upsideon commented 2 years ago

Fixes #12 by following the instructions provided in the issue:

A post_build method has been added to the Element class which is called in Element.produce_impl following a call to build.
The Chip.build method has been renamed to Chip.post_build.
All super().build() calls have been removed from chips as well as the associated documentation for implementing new chips.

All tests pass locally, so chips should continue to be constructed properly following these changes.

iqmtestd commented 2 years ago

The code looks OK to me. Everything works, let's merge it.