search

iqm-finland / KQCircuits

KLayout Python library for integrated quantum circuit design.
GNU General Public License v3.0
128 stars 71 forks source link

[unitaryhack] Fixes links to files in Documentation. #18

Closed divshacker closed 2 years ago

divshacker commented 2 years ago

fixes #9

jkotilahti commented 2 years ago

Thanks for the contribution @divshacker! We will review this later today. Please note that you must sign the IQM CLA as mentioned here in order for us to accept your PR.

divshacker commented 2 years ago

I was planning to push all the changes first and then test links later. So maybe some of the links will not work in between. There are many links which are needed to be added so it require some time to do this. Please give me 2 -3 days Untill I add all the links and test it. I will then notify you to please review the PR. Also thanks for the suggestions. I have signed CLA.

jkotilahti commented 2 years ago

Sounds good! I wasn't sure if you were planning to add more links, I will wait now until you request review :)

divshacker commented 2 years ago

Hey @jkotilahti I have done all the changes as suggested. Please check and let me know if there is any changes required. Thanks

jkotilahti commented 2 years ago

Thanks, I will check today.

divshacker commented 2 years ago

Done with changes you suggested @jkotilahti. Also, thanks for pointing out mistakes. Let me know if there is any other change required. Thanks