FlipChipConnectorRf inconsistent between round and square connector shape - Githubissues

iqm-finland / KQCircuits

KLayout Python library for integrated quantum circuit design.

GNU General Public License v3.0

142 stars 73 forks source link

FlipChipConnectorRf inconsistent between round and square connector shape #56

Closed qpavsmi closed 9 months ago

qpavsmi commented 1 year ago

Description

The geometry for FlipChipConnectorRf with round_connector=True and round_connector=False are not consistent:

The port name is f"{face_id}_port" for round connector, but empty string for square connector.
When using n_center_bumps > 1 and output_rotation != 180, the geometry of top and bottom face do not overlap. Instead of rotating only the output, the whole shape is rotated. This was fixed for round connector already, but is not yet fixed for square connector:

Acceptance criteria

Fix the multi-bump output rotation geometry to match that of round_connector
Change port names to f"{face_id}_port" in square connector. This might break some tests

Use case

No response

iqmtestd commented 11 months ago

Refpoints are seemingly all right for the square connector too in GUI:

Also when trying to get them in code:

cell, refp = FlipChipConnectorRf.create_with_refpoints(layout, face_ids=['1t1', '2b1'], round_connector=False)
refp['1t1_port']